fix(model_splitter): fix spurious ssm creation#2716
Merged
wpbonelli merged 1 commit intomodflowpy:developfrom Feb 25, 2026
Merged
fix(model_splitter): fix spurious ssm creation#2716wpbonelli merged 1 commit intomodflowpy:developfrom
wpbonelli merged 1 commit intomodflowpy:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2716 +/- ##
===========================================
+ Coverage 55.5% 72.4% +16.9%
===========================================
Files 644 674 +30
Lines 124135 130548 +6413
===========================================
+ Hits 68947 94595 +25648
+ Misses 55188 35953 -19235
🚀 New features to boost your workflow:
|
jlarsen-usgs
approved these changes
Feb 25, 2026
Contributor
jlarsen-usgs
left a comment
There was a problem hiding this comment.
@wpbonelli, this looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The model splitter generated empty SSM package files for partitions containing no boundary conditions, causing MODFLOW 6 to fail.
The
_remap_ssm()method set a dict entry toNoneto indicate a partition had no boundary flows. Later the dict is checked in anifstatement and considered "truthy" since it contains an entry whose value isNoneInstead, indicate no boundary flows by not adding an entry to the dict. The conditional works, no SSM package is created, no file written, MF6 is happy.
Fix #2715