Use native Python double precision float for SFR2#300
Closed
mwtoews wants to merge 9 commits into
Closed
Conversation
Contributor
Author
|
Closing as this issue with SFR2 formatting is primarily addressed in #313 However, there are potentially outstanding issues with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flopy's SFR2 package adds superfluous digits to output files from native Python
floattypes, which is double precision. Let me demonstrate:And the
x.sfroutput file:The fix that I've put together in this PR is to switch from
float32(a.k.a.real) tofloat(a.k.a.double precision).I haven't dug down to SFR2's writer/formatter, but it's possible to get Numpy to output
float32(or any other data type) as it should:Other fixes in this PR add other floats to
NC_PRECISION_TYPE. Also np.int64 was corrected from "i4" to "i8".