Merged
Conversation
… systems (cf. Docker/Alpine). The invalid path is the first one : `modx-2.3.5-pl/./`, this path cause an error while unzipping : `unzip: can't create directory 'modx-2.3.5-pl/./': File exists`
…Gitify installation with the same data/backup directories.
Member
|
Hey @krismas, thanks for your contributions - I will be getting Gitify up to date and merge stuff in soon. Could you make sure to branch each PR off the primary (master) branch again, rather than your own updated branch? As you can see, this PR contains all of the other PR commits as well making it a bit harder to review. I'll just merge them in the way you submitted them to be able of properly reviewing them individually, but if you could keep an eye on that in the future that'd be great :) |
Member
|
Thanks @krismas, all your PRs are now merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
PHP Warning: mkdir(): File existswhen overwriting previous Gitify installation with the same data/backup directories.