Cached downloads of modx#133
Cached downloads of modx#133Mark-H merged 3 commits intomodmore:masterfrom alroniks:cached_downloads_of_modx
Conversation
src/Mixins/DownloadModx.php
Outdated
There was a problem hiding this comment.
Typo in method name, should be retrieveFromCache
|
Fixed typo :) |
There was a problem hiding this comment.
Before this line should be an index check
if (isset($_SERVER['HOME']) {
...Otherwise this line will throw:
PHP Notice: Undefined index: HOME ...
There was a problem hiding this comment.
Hm, strange. I use isset() special for check this array key
|
I tested it just now and on my Windows setup (it's not standard windows, because I use scoop) and is working fine (except it will not install MODX because of problem with Windows file paths - this we should fix with Mark as other issue). Will be great to have same function for packages ;) |
|
Packages are installing via modx, so it's some difficult store their local. Especially checking updates and download. But good direction, I need to think. |
Added support caching downloaded MODX archives for avoid downloading every time.
How it works.
Gitify try download package to
/home/user/.gitifyfolder and if you try install MODX next time Gitify will check local storage and copy folder with modx from local folder.Also you can force downloading with flag --download (-d)Gitify modx:install -d- forcedGitify modx:install- as usualAlso I've added command clearcache, that remove all cached versions and remove .gitify folder from home directory
Gitify clearcachePlease, test on Windows, if somobedy can, because I don't have abbility do it now.