Skip to content

Modrinth Uninstaller recursively enters symlinks and deletes out of scope user files #4280

@AdamFeiss

Description

@AdamFeiss

Please confirm the following.

  • I checked the existing issues for duplicate problems
  • I have tried resolving the issue using the support portal
  • I have ensured my Modrinth App installation is up to date

What version of the Modrinth App are you using?

Modrinth App_0.9.5_x64-setup

What operating systems are you seeing the problem on?

Windows

Describe the bug

I was using the modrinth app to manage multiple minecraft instances to develop and backport shaders/resourcepacks

My project files were under my user directory and /Documents/MinecraftWorkspace (resourcepacks located here)/ shaders (shaders located here).
In order to do live runtime testing with my assets, I replaced the resourcepacks / shaders folder in my instances with symlinks pointing to the workspace directory (MCWorkspace for resourcepacks and McWorkspace/shaders for shaders).

When updating to the latest version, some sort of installer issue occurred, and I chose to just do a clean install, since "nothing important" was inside my instances. Checked the box to "Delete app related data" in the uninstaller.

Every single file/folder inside the Mcworkspace was permanently deleted (even hidden files like .git, .vscode, etc.).
Interestingly enough, only the folders inside the "shaders" folder remained untouched, but files inside them also have been recursively deleted.

Obviously this should not happen, as related deletes should not just blindly recursively delete files under a certain directory, especially those only symlinked in.

Kind regards, and I hope you guys figure this one out.

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    appRelates to Modrinth App📂 Under review[Triage] Is being reviewed by Modrinth Staff for future roadmap consideration.

    Type

    No fields configured for Bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions