Add align to img, p, and div & allow h1 to be centered#2231
Merged
Prospector merged 9 commits intomainfrom Aug 23, 2024
Merged
Conversation
Signed-off-by: Jakob <minenash@protonmail.com>
Signed-off-by: Jakob <minenash@protonmail.com>
github-actions
bot
temporarily deployed
to
Preview (markdown-align-for-img-p-div)
Signed-off-by: Jakob <minenash@protonmail.com>
github-actions
bot
requested a deployment
to
Preview (markdown-align-for-img-p-div)
Signed-off-by: Jakob <minenash@protonmail.com>
github-actions
bot
temporarily deployed
to
Preview (markdown-align-for-img-p-div)
Minenash
changed the title
Contributor
Author
|
I still need to quickly fix the h1 thing. Another style overrides it |
github-actions
bot
temporarily deployed
to
Preview (markdown-align-for-img-p-div)
github-actions
bot
temporarily deployed
to
Preview (markdown-align-for-img-p-div)
github-actions
bot
temporarily deployed
to
Preview (markdown-align-for-img-p-div)
Prospector
approved these changes
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes omorphia#182 which superseded knossos#1401 which fixes knossos#1207 but also adds it to p and div for better Github Markdown compatibility.
In the knossos PR, I had to add
overflow:yto.markdown-body, however at least when testing in omorphia's docs page for the omorphia PR, no css change was needed.Not 100% how to test this under the new mono-repo system, but I don't think anything change since the omorphia PR
This PR also allows h1 to be centered in markdown by making it's display no longer flex, but instead block which matches the rest of the headers. This fixes #1539