Implement a more robust IPC system between the launcher and client #4159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaming32
added
enhancement
app
AlexTMjugador
suggested changes
Aug 12, 2025
Contributor
AlexTMjugador
left a comment
AlexTMjugador
left a comment
There was a problem hiding this comment.
Thanks! The approach looks nice overall, though I have some thoughts I feel need addressing before merging.
packages/app-lib/java/src/main/java/com/modrinth/theseus/rpc/TheseusRpc.java
Show resolved
Hide resolved
packages/app-lib/java/src/main/java/com/modrinth/theseus/rpc/TheseusRpc.java
Outdated
Show resolved
Hide resolved
packages/app-lib/java/src/main/java/com/modrinth/theseus/rpc/TheseusRpc.java
Outdated
Show resolved
Hide resolved
AlexTMjugador
approved these changes
Aug 13, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 18, 2025
* Reapply "Implement a more robust IPC system between the launcher and client (#4159)" This reverts commit e25d726. * Put game JAR and theseus JAR ahead of other JARs in classpath * Fix 1.17-1.20 Forge by forcefully removing Multi-Release manifest entry * Fix formatting --------- Co-authored-by: Prospector <6166773+Prospector@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a primitive stdin IPC system, this PR replaces it with a more robust JSON-based system, which will allow bidirectional whenever we want, instead of just at game launch.