Fix IPC on Forge 1.17.1 - 1.20.1 #4187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This can also be simplified greatly when/if GradleUp/shadow#1661 is fixed. |
Prospector
approved these changes
Aug 16, 2025
Member
Prospector
left a comment
Prospector
left a comment
There was a problem hiding this comment.
Tested on many various MC versions and loaders, and it seems to work! not a code review though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by
Multi-Releasegetting added to the theseus.jar manifest by shadow.Multi-Releasegets added by shadow because gson hasMulti-Releaseset totrue, however shadow strips the actual versions directory, as gson only has amodule-info.classin there. However, older versions of SecureJarHandler crash if Multi-Release is set to true but the versions directory is missing.It is recommended to review this PR commit by commit, as its first commit is just re-adding IPC.