Window occlusion checks on MacOS#6135
Merged
Merged
Conversation
Member
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
aecsocket
force-pushed
the
boris/window-occlusion-macos
branch
from
0512e64 to
1f39334
Compare
fetchfern
requested changes
May 20, 2026
Comment on lines
+16
to
+25
| pub fn main_window_id(ns_window: *mut std::ffi::c_void) -> Option<CGWindowID> { | ||
| if ns_window.is_null() { | ||
| return None; | ||
| } | ||
|
|
||
| let window_number = | ||
| unsafe { (ns_window as *mut NSWindow).as_ref()?.windowNumber() }; | ||
|
|
||
| (window_number > 0).then_some(window_number as CGWindowID) | ||
| } |
Member
There was a problem hiding this comment.
This function should be marked unsafe
Contributor
Author
There was a problem hiding this comment.
Rewrote to inline this function, since a func taking a ns_window: c_void and blind casting is stupid - just do this in the flow which gets the window.
fetchfern
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.