[stdlib] Fix argument convention for iota#3261
Closed
soraros wants to merge 1 commit intomodular:nightlyfrom
Closed
[stdlib] Fix argument convention for iota#3261soraros wants to merge 1 commit intomodular:nightlyfrom
iota#3261soraros wants to merge 1 commit intomodular:nightlyfrom
Conversation
Signed-off-by: Yiwu Chen <210at85@gmail.com>
Contributor
|
!sync |
modularbot
added
the
imported-internally
Collaborator
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
modularbot
pushed a commit
that referenced
this pull request
Jul 24, 2024
[External] [stdlib] Fix argument convention for `iota` - The `List` arguments should be `inout`. - Improved the docstinrg a bit. - Make `DType` parameter infer-only. Co-authored-by: soraros <soraros@users.noreply.github.com> Closes #3261 MODULAR_ORIG_COMMIT_REV_ID: 0aad112d2b696e42a6b199299b83054e3c4be591
Collaborator
|
Landed in c3398db! Thank you for your contribution 🎉 |
modularbot
pushed a commit
that referenced
this pull request
Sep 13, 2024
[External] [stdlib] Fix argument convention for `iota` - The `List` arguments should be `inout`. - Improved the docstinrg a bit. - Make `DType` parameter infer-only. Co-authored-by: soraros <soraros@users.noreply.github.com> Closes #3261 MODULAR_ORIG_COMMIT_REV_ID: 0aad112d2b696e42a6b199299b83054e3c4be591
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listarguments should beinout.DTypeparameter infer-only.