[stdlib] Deque - don't use non-self out args#3851
Closed
avitkauskas wants to merge 1 commit intomodular:nightlyfrom
Closed
[stdlib] Deque - don't use non-self out args#3851avitkauskas wants to merge 1 commit intomodular:nightlyfrom
avitkauskas wants to merge 1 commit intomodular:nightlyfrom
Conversation
Signed-off-by: Alvydas Vitkauskas <alvydas.vitkauskas@gmail.com>
Contributor
Author
|
Pre-commit fails because of reformating of |
Member
Don't worry about this right now. @keith and @walter-erquinigo are looking into it. See #3832. |
JoeLoser
approved these changes
Dec 10, 2024
Member
|
!sync |
modularbot
added
the
imported-internally
Collaborator
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
merged-internally
Collaborator
|
Landed in 8123754! Thank you for your contribution 🎉 |
modularbot
pushed a commit
that referenced
this pull request
Dec 11, 2024
[External] [stdlib] Deque - don't use non-self out args As the original author of the Deque, I would like to propose to not use the `out` args instead of `-> ElementType as element` in `pop()` and `popleft()` methods. The named return variable was just a simple convenience in these functions and not needed at all. In general, having something in the args list of the function that you do not pass to the function at the call site looks weird (except for constructors). In my opinion, it makes the function signature just less clear to read and the return type of the function unnecessarily hidden inside the args list. So, let's just use normal return statements here and have a clear function signatures. Co-authored-by: Alvydas Vitkauskas <alvydas.vitkauskas@gmail.com> Closes #3851 MODULAR_ORIG_COMMIT_REV_ID: acae8a18cea7f91639d059e03dff88e3e3d1f5a5
modularbot
pushed a commit
that referenced
this pull request
Feb 13, 2025
[External] [stdlib] Deque - don't use non-self out args As the original author of the Deque, I would like to propose to not use the `out` args instead of `-> ElementType as element` in `pop()` and `popleft()` methods. The named return variable was just a simple convenience in these functions and not needed at all. In general, having something in the args list of the function that you do not pass to the function at the call site looks weird (except for constructors). In my opinion, it makes the function signature just less clear to read and the return type of the function unnecessarily hidden inside the args list. So, let's just use normal return statements here and have a clear function signatures. Co-authored-by: Alvydas Vitkauskas <alvydas.vitkauskas@gmail.com> Closes #3851 MODULAR_ORIG_COMMIT_REV_ID: acae8a18cea7f91639d059e03dff88e3e3d1f5a5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the original author of the Deque, I would like to propose to not use the
outargs instead of-> ElementType as elementinpop()andpopleft()methods.The named return variable was just a simple convenience in these functions and not needed at all.
In general, having something in the args list of the function that you do not pass to the function at the call site looks weird (except for constructors). In my opinion, it makes the function signature just less clear to read and the return type of the function unnecessarily hidden inside the args list.
So, let's just use normal return statements here and have a clear function signatures.