[stdlib] Remove StringRef starts and endswith#3867
Closed
martinvuyk wants to merge 3 commits intomodular:nightlyfrom
Closed
[stdlib] Remove StringRef starts and endswith#3867martinvuyk wants to merge 3 commits intomodular:nightlyfrom
StringRef starts and endswith#3867martinvuyk wants to merge 3 commits intomodular:nightlyfrom
Conversation
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
JoeLoser
approved these changes
Dec 13, 2024
Member
|
FYI @ConnorGray - any concerns? |
Member
|
!sync |
modularbot
added
the
imported-internally
ConnorGray
reviewed
Dec 13, 2024
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
Member
|
!sync |
Member
|
Awesome, thank you so much for moving that over Martin! 🫶 This LGTM, and I resynced to pick up your changes. |
Collaborator
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
modularbot
pushed a commit
that referenced
this pull request
Dec 14, 2024
[External] [stdlib] Remove `StringRef` starts and endswith Remove `StringRef` `startswith` and `endswith`. We already have this in `StringSlice`. Co-authored-by: martinvuyk <110240700+martinvuyk@users.noreply.github.com> Closes #3867 MODULAR_ORIG_COMMIT_REV_ID: 6e510ad4bd401110aa4cb1172f3c4c60dfef2628
Collaborator
|
Landed in 08a874d! Thank you for your contribution 🎉 |
modularbot
pushed a commit
that referenced
this pull request
Feb 13, 2025
[External] [stdlib] Remove `StringRef` starts and endswith Remove `StringRef` `startswith` and `endswith`. We already have this in `StringSlice`. Co-authored-by: martinvuyk <110240700+martinvuyk@users.noreply.github.com> Closes #3867 MODULAR_ORIG_COMMIT_REV_ID: 6e510ad4bd401110aa4cb1172f3c4c60dfef2628
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
StringRefstarts and endswithWe already have this in
StringSlice