Skip to content

[stdlib] Add gfx1030 RX 6900 support#4833

Closed
farnoy wants to merge 1 commit intomodular:mainfrom
farnoy:rdna2-6900
Closed

[stdlib] Add gfx1030 RX 6900 support#4833
farnoy wants to merge 1 commit intomodular:mainfrom
farnoy:rdna2-6900

Conversation

@farnoy
Copy link
Copy Markdown
Contributor

@farnoy farnoy commented Jun 14, 2025

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 21, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@farnoy farnoy changed the title Add gfx1030 RX 6900 support [stdlib] Add gfx1030 RX 6900 support Jun 21, 2025
@farnoy
Copy link
Copy Markdown
Contributor Author

farnoy commented Jun 21, 2025

I have read the CLA Document and I hereby sign the CLA

modular-cla-bot bot added a commit to modular/cla that referenced this pull request Jun 21, 2025
@farnoy farnoy marked this pull request as ready for review June 21, 2025 20:47
@farnoy farnoy requested review from a team as code owners June 21, 2025 20:47
@JoeLoser JoeLoser requested a review from a team June 26, 2025 05:37
@JoeLoser
Copy link
Copy Markdown
Member

JoeLoser commented Aug 6, 2025

LGTM, can you please also add a changelog entry here? Happy to sync and land this after that is done. Thanks!

Do all of the stdlib/kernel tests pass on your RX 6900?

@farnoy farnoy force-pushed the rdna2-6900 branch 2 times, most recently from a5cfbb4 to 955dc3b Compare August 6, 2025 16:30
@farnoy
Copy link
Copy Markdown
Contributor Author

farnoy commented Aug 6, 2025

Should be clean now. No, not all of the tests pass, I think far from it but I haven't used this one in a while. I swapped to a radeon VII which is closer to the CDNA uarch which has better support and lets me develop other features there.

@JoeLoser
Copy link
Copy Markdown
Member

JoeLoser commented Aug 6, 2025

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Aug 6, 2025
@modularbot
Copy link
Copy Markdown
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the main branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added the merged-internally Indicates that this pull request has been merged internally label Aug 7, 2025
@BradLarson
Copy link
Copy Markdown
Member

@farnoy - Very cool, thanks! I know all the stdlib tests didn't pass, but did you see any of the GPU function examples in Mojo work on this GPU? I wasn't entirely sure that RDNA2 ROCm would work, could only test on RDNA3 devices. I can also have other folks with similar RDNA2 GPUs test this out, now that it's in the nightlies.

@modularbot
Copy link
Copy Markdown
Collaborator

Landed in bd780fb! Thank you for your contribution 🎉

@modularbot modularbot added the merged-externally Merged externally in public mojo repo label Aug 8, 2025
@modularbot modularbot closed this in bd780fb Aug 8, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2025
@farnoy farnoy deleted the rdna2-6900 branch August 12, 2025 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

imported-internally Signals that a given pull request has been imported internally. merged-externally Merged externally in public mojo repo merged-internally Indicates that this pull request has been merged internally

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants