[stdlib][NFC] Move code in _cpython.mojo to reduce the diff size for subsequent patches#5048
Closed
soraros wants to merge 7 commits intomodular:mainfrom
Closed
[stdlib][NFC] Move code in _cpython.mojo to reduce the diff size for subsequent patches#5048soraros wants to merge 7 commits intomodular:mainfrom
_cpython.mojo to reduce the diff size for subsequent patches#5048soraros wants to merge 7 commits intomodular:mainfrom
Conversation
Contributor
Author
|
The diff algorithm isn't smart enough to recognise that I'm only moving code around, though it's fairly trivial to see that from the individual commits. |
soraros
force-pushed
the
cpython-api-move-code
branch
from
c8c74ff to
4286425
Compare
…r subsequent patches - Move tuple and list. Signed-off-by: sora <210at85@gmail.com>
Signed-off-by: sora <210at85@gmail.com>
Signed-off-by: sora <210at85@gmail.com>
Signed-off-by: sora <210at85@gmail.com>
Signed-off-by: sora <210at85@gmail.com>
Signed-off-by: sora <210at85@gmail.com>
Signed-off-by: sora <210at85@gmail.com>
soraros
force-pushed
the
cpython-api-move-code
branch
from
4286425 to
a97dca3
Compare
laszlokindrat
approved these changes
Jul 21, 2025
Contributor
laszlokindrat
left a comment
laszlokindrat
left a comment
There was a problem hiding this comment.
Thanks, this should make subsequent reviews easier!
Contributor
|
!sync |
modularbot
added
the
imported-internally
Collaborator
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the main branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
merged-internally
Collaborator
|
Landed in c3c0dcc! Thank you for your contribution 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.