Skip to content

[stdlib] [mojo] Implement set_all for bitset#5092

Closed
AceMouse wants to merge 3 commits intomodular:mainfrom
AceMouse:set_all
Closed

[stdlib] [mojo] Implement set_all for bitset#5092
AceMouse wants to merge 3 commits intomodular:mainfrom
AceMouse:set_all

Conversation

@AceMouse
Copy link
Copy Markdown
Contributor

AceMouse added 2 commits July 26, 2025 13:50
Signed-off-by: Asmus Tørsleff <asmus.torsleff@gmail.com>
Signed-off-by: Asmus Tørsleff <asmus.torsleff@gmail.com>
@AceMouse AceMouse requested a review from a team as a code owner July 26, 2025 11:58
@AceMouse AceMouse changed the title Implement set_all for bitset [stdlib] [mojo] Implement set_all for bitset Jul 26, 2025
@AceMouse
Copy link
Copy Markdown
Contributor Author

Seems the Ubuntu test fails because it was cancelled?
If this is the case please re-run it before syncing :)
Otherwise let me know if there is something I should change.

@abduld
Copy link
Copy Markdown
Contributor

abduld commented Jul 26, 2025

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Jul 26, 2025
Signed-off-by: Asmus Tørsleff <asmus.torsleff@gmail.com>
@AceMouse
Copy link
Copy Markdown
Contributor Author

Hey @abduld I forgot to actually run the test, now it should be good to sync though.

Pardon the oversight and have a nice weekend,
Asmus

Copy link
Copy Markdown
Member

@JoeLoser JoeLoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!sync

@JoeLoser
Copy link
Copy Markdown
Member

!sync

@modularbot
Copy link
Copy Markdown
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the main branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added merged-internally Indicates that this pull request has been merged internally merged-externally Merged externally in public mojo repo labels Jul 26, 2025
@modularbot
Copy link
Copy Markdown
Collaborator

Landed in 5083a65! Thank you for your contribution 🎉

@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

imported-internally Signals that a given pull request has been imported internally. merged-externally Merged externally in public mojo repo merged-internally Indicates that this pull request has been merged internally

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] [mojo] [stdlib] BitSet set_all()

4 participants