Skip to content

Conversation

@msaelices
Copy link
Contributor

In order to make the NMS code easier to understand to contributors:

  • Added docstrings to the entire nms module
  • Polished current code comments

Signed-off-by: Manuel Saelices <msaelices@gmail.com>
It's now slightly easier to understand the algorithm

Signed-off-by: Manuel Saelices <msaelices@gmail.com>
@msaelices msaelices requested a review from a team as a code owner October 5, 2025 15:39
@abduld
Copy link
Contributor

abduld commented Oct 5, 2025

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Oct 5, 2025
@modularbot
Copy link
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the main branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added the merged-internally Indicates that this pull request has been merged internally label Oct 6, 2025
@modularbot
Copy link
Collaborator

Landed in 1757451! Thank you for your contribution 🎉

@modularbot modularbot added the merged-externally Merged externally in public mojo repo label Oct 6, 2025
@modularbot modularbot closed this in 1757451 Oct 6, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

imported-internally Signals that a given pull request has been imported internally. merged-externally Merged externally in public mojo repo merged-internally Indicates that this pull request has been merged internally

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants