[Kernels] migrate-MOGGIntList-to-UnsafePointer#5792
Closed
turakz wants to merge 1 commit into
Closed
Conversation
turakz
changed the title
1 task
JoeLoser
approved these changes
Jan 18, 2026
Member
JoeLoser
left a comment
JoeLoser
left a comment
There was a problem hiding this comment.
LGTM but consider my one cleanup comment 👍
BEGIN_PUBLIC [Kernels] 5672-migrate-MOGGIntList-to-UnsafePointer migrates MOGGIntList.mojo from LegacyUnsafePointer to UnsafePointer changes: - struct owned pointer to align with alloc calls (`MutExternalOrigin`) - refactors static func alloc calls to free func alloc calls - removes redundant null-check in `fn __del__` END_PUBLIC Signed-off-by: turakz <zachary.turak@gmail.com>
turakz
force-pushed
the
5672-migrate-MOGGIntList-to-UnsafePointer
branch
from
74d358e to
1701ae6
Compare
Contributor
|
!sync |
modularbot
added
the
imported-internally
Collaborator
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the main branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
merged-internally
Collaborator
|
Landed in 1b26a58! Thank you for your contribution 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
migrates
Mogg/MOGGPrimitives/MOGGIntList.mojotoUnsafePointer.kernels/src/Moggoff ofLegacyUnsafePointer. #5672 (comment)Test Plan
./bazelw build //max/kernels/...passes./bazelw test //max/kernels/test/...passes