Skip to content

[MAX] Add v2 Qwen3 text encoder for diffusion pipelines#6266

Closed
pei0033 wants to merge 3 commits intomodular:mainfrom
SqueezeBits:v2-migration/qwen3-textencoder
Closed

[MAX] Add v2 Qwen3 text encoder for diffusion pipelines#6266
pei0033 wants to merge 3 commits intomodular:mainfrom
SqueezeBits:v2-migration/qwen3-textencoder

Conversation

@pei0033
Copy link
Copy Markdown
Contributor

@pei0033 pei0033 commented Mar 24, 2026

Summary

Adds a v2 qwen3/text_encoder implementation for diffusion pipelines.

This migrates the Qwen3 text encoder off the module v3 max.experimental path and keeps the file hierarchy and code order aligned with the existing module v3 implementation to simplify review and follow-on changes.

Testing

  • ./bazelw run //max/examples/diffusion:simple_offline_generation --config=disable-mypy -- --model black-forest-labs/FLUX.2-klein-4B --prompt 'a small test image of a cat' --height 256 --width 256 --num-inference-steps 1 --num-warmups 0 --guidance-scale 1.0 --seed 42 --output v2.png

Checklist

  • PR is small and focused — consider splitting larger changes into a
    sequence of smaller PRs
  • I ran ./bazelw run format to format my changes
  • I added or updated tests to cover my changes
  • If AI tools assisted with this contribution, I have included an
    Assisted-by: trailer in my commit message or this PR description
    (see AI Tool Use Policy)

Assisted-by: Codex

@pei0033 pei0033 requested a review from a team as a code owner March 24, 2026 13:21
@ansley
Copy link
Copy Markdown
Contributor

ansley commented Mar 30, 2026

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Mar 30, 2026
@modularbot
Copy link
Copy Markdown
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the main branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added merged-internally Indicates that this pull request has been merged internally merged-externally Merged externally in public mojo repo labels Mar 30, 2026
@modularbot
Copy link
Copy Markdown
Collaborator

Landed in 18fb0e9! Thank you for your contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

imported-internally Signals that a given pull request has been imported internally. merged-externally Merged externally in public mojo repo merged-internally Indicates that this pull request has been merged internally waiting-on-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants