[MAX] Add v2 Qwen3 text encoder for diffusion pipelines#6266
Closed
pei0033 wants to merge 3 commits intomodular:mainfrom
Closed
[MAX] Add v2 Qwen3 text encoder for diffusion pipelines#6266pei0033 wants to merge 3 commits intomodular:mainfrom
pei0033 wants to merge 3 commits intomodular:mainfrom
Conversation
4 tasks
Contributor
|
!sync |
Collaborator
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the main branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
Collaborator
|
Landed in 18fb0e9! Thank you for your contribution 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a v2
qwen3/text_encoderimplementation for diffusion pipelines.This migrates the Qwen3 text encoder off the module v3
max.experimentalpath and keeps the file hierarchy and code order aligned with the existing module v3 implementation to simplify review and follow-on changes.Testing
./bazelw run //max/examples/diffusion:simple_offline_generation --config=disable-mypy -- --model black-forest-labs/FLUX.2-klein-4B --prompt 'a small test image of a cat' --height 256 --width 256 --num-inference-steps 1 --num-warmups 0 --guidance-scale 1.0 --seed 42 --output v2.pngChecklist
sequence of smaller PRs
./bazelw run formatto format my changesAssisted-by:trailer in my commit message or this PR description(see AI Tool Use Policy)
Assisted-by: Codex