Mark PRs temporarily draft while submitting #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `stack-pr submit`, patches in a stack need to have their base branches temporarily changed to avoid accidental closures. This has the unfortunate side effect that in this transient state, the PRs seem like multi-commit PRs pointing to main, resulting in GH notifying reviewers for every commit on the branch (as opposed to just the one that corresponds to the stacked PR). This patch fixes this by marking PRs temporarily draft while we manipulate their bases. stack-info: PR: #111, branch: laszlokindrat/stack/2
laszlokindrat
pushed a commit
that referenced
this pull request
Dec 2, 2025
When running `stack-pr submit`, patches in a stack need to have their base branches temporarily changed to avoid accidental closures. This has the unfortunate side effect that in this transient state, the PRs seem like multi-commit PRs pointing to main, resulting in GH notifying reviewers for every commit on the branch (as opposed to just the one that corresponds to the stacked PR). This patch fixes this by marking PRs temporarily draft while we manipulate their bases. stack-info: PR: #111, branch: laszlokindrat/stack/2
laszlokindrat
force-pushed
the
laszlokindrat/stack/2
branch
from
a8835f6 to
454193f
Compare
laszlokindrat
force-pushed
the
laszlokindrat/stack/1
branch
from
dd5133d to
6f0725a
Compare
bhansconnect
approved these changes
Dec 3, 2025
ZolotukhinM
approved these changes
Dec 4, 2025
ZolotukhinM
force-pushed
the
laszlokindrat/stack/2
branch
from
454193f to
9b255aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
landoption when it's disabled #110Mark PRs temporarily draft while submitting
When running
stack-pr submit, patches in a stack need to have their base branches temporarily changed to avoid accidental closures. This has the unfortunate side effect that in this transient state, the PRs seem like multi-commit PRs pointing to main, resulting in GH notifying reviewers for every commit on the branch (as opposed to just the one that corresponds to the stacked PR). This patch fixes this by marking PRs temporarily draft while we manipulate their bases.