Remove endpoint URL generation from fetch-models script#19
Merged
Conversation
- Detect data URI logo_url values and decode to data/images/ - Replace with public jsDelivr CDN URLs for Webflow CMS consumption - Clear and recreate images dir each run to remove stale files - Update CI workflow to commit data/images/ alongside models.json - Gitignore docs/ directory
- All models now use api.modular.com, no per-model endpoint URLs needed - Remove fetchEndpoint(), toSubdomain(), and API_DOMAIN constant - Remove endpoint_url field from transformModel output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api.modular.comfetchEndpoint(),toSubdomain(),API_DOMAINconstant, andendpoint_urlfield from model outputNotes
data/models.jsonwas regenerated by the "Fetch Model Garden" GH Action after this changeChanges
Scripts
scripts/fetch-models.jsendpoint_urlfrom transformed outputData
data/models.jsonendpoint_urlfield removed