Conversation
There was a problem hiding this comment.
Pull request overview
Updates the release publishing automation to publish @module-federation/astro directly from packages/astro (avoiding npm workspace flags) and aligns the release documentation with the repo’s pnpm-workspace.yaml setup.
Changes:
- Switch prerelease version patching from
npm ... --workspacetonpm pkg set ... --prefix packages/astro. - Publish using
working-directory: packages/astroinstead of npm workspace targeting. - Update release docs to note publishing from the package directory and clarify pnpm workspaces vs root npm workspaces.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
docs/RELEASING.md |
Updates release docs to reflect publishing from packages/astro and correct workspace expectations. |
.github/workflows/publish-on-release.yml |
Removes reliance on npm workspace discovery by patching/publishing from packages/astro. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - On `prereleased` events, workflow patches `packages/astro/package.json` to `<base>-next.<N>` before publish. | ||
| - npm publish runs from `packages/astro` directly; this repo uses `pnpm-workspace.yaml`, not root npm workspaces. |
There was a problem hiding this comment.
The bullets under “Pre-release versioning:” are mis-indented (lines 31–32). As written, they won’t render as nested bullets under that heading, unlike the “Existing version handling” section below. Align these list items’ indentation with the other nested bullets (e.g., indent to the same level as lines 34–35).
| - On `prereleased` events, workflow patches `packages/astro/package.json` to `<base>-next.<N>` before publish. | |
| - npm publish runs from `packages/astro` directly; this repo uses `pnpm-workspace.yaml`, not root npm workspaces. | |
| - On `prereleased` events, workflow patches `packages/astro/package.json` to `<base>-next.<N>` before publish. | |
| - npm publish runs from `packages/astro` directly; this repo uses `pnpm-workspace.yaml`, not root npm workspaces. |
| - name: Publish to npm | ||
| if: steps.publish_action.outputs.action == 'publish' | ||
| run: npm publish --provenance --tag "${{ steps.dist.outputs.dist_tag }}" --access public --workspace packages/astro | ||
| working-directory: packages/astro | ||
| run: npm publish --provenance --tag "${{ steps.dist.outputs.dist_tag }}" --access public |
There was a problem hiding this comment.
This workflow no longer uses npm workspaces, but the repo still contains .github/workflows/release.yml which runs npm publish ... --workspace packages/astro (and will hit the same “No workspaces found” error described in the PR). If that workflow is still intended to be used, it should be updated similarly (publish from packages/astro or use --prefix), or removed to avoid a broken release path.
What changed
npm ... --workspace packages/astroin the release publish workflownpm pkg set --prefix packages/astropackages/astroas the working directorypnpm-workspace.yaml, not root npm workspacesWhy
The publish workflow failed with:
This repo does not define root npm workspaces, so npm workspace flags are the wrong mechanism in CI. The package needs to be mutated and published from its directory directly.
Impact
packages/astrocorrectlyValidation
pnpm --filter @module-federation/astro testcd packages/astro && npm publish --dry-run --access public --tag latest