chore(typescript): drop lodash.get dependency#4705
Conversation
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: e0d2aaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@2heal1 Is there anything stopping from these 3 dependency cleanups to be merged? Otherwise I'd close the PRs. I apologize for the ping 🙈 |
|
Could you please rebase this branch on the latest |
d750260 to
1929195
Compare
|
@2heal1 Rebased this and the two other PRs |
1929195 to
372f944
Compare
dec0377 to
026e083
Compare
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/esbuild
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/metro-plugin-rock
@module-federation/modern-js
@module-federation/modern-js-v3
@module-federation/native-federation-tests
@module-federation/native-federation-typescript
@module-federation/nextjs-mf
@module-federation/node
@module-federation/observability-plugin
@module-federation/playground
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/storybook-addon
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/typescript
@module-federation/utilities
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
The optional-chaining rewrite is behavior-equivalent to lodash.get, including the edge case where devServer.static is an array (both return undefined and fall through to output.path). The cast is necessary since webpack's Compiler['options'] does not type devServer. Checked repo-wide: nothing else consumes lodash.get, so the root devDependency removal is safe, and the package is formally deprecated upstream. Builds clean on the updated branch.
Bundle Size Report12 package(s) changed, 30 unchanged. Package dist + ESM entry
Bundle targets
Consumer scenarios
Total dist (raw): 35.63 MB (-111 B (-0.0%)) Bundle sizes are generated with rslib (Rspack). Package-root metrics preserve the historical report. Tracked subpath exports such as |
6b22938
into
module-federation:main
Description
Drop dependency
lodash.getin typescript package and replace it with optional chaining.Related Issue
Types of changes
Checklist