Skip to content

docs(bridge-react): fix loading option example#4777

Merged
2heal1 merged 2 commits into
mainfrom
fix/4599-react-loading-docs
May 28, 2026
Merged

docs(bridge-react): fix loading option example#4777
2heal1 merged 2 commits into
mainfrom
fix/4599-react-loading-docs

Conversation

@2heal1
Copy link
Copy Markdown
Member

@2heal1 2heal1 commented May 28, 2026

What changed

Fixes #4599.

The React bridge docs now pass the loading option as a rendered element instead of a component function in both English and Chinese docs.

Why

The documented API expects a React node, so the previous example could lead users to copy an invalid shape.

Validation

  • pnpm exec prettier --check apps/website-new/docs/en/guide/bridge/react/load-app.mdx apps/website-new/docs/zh/guide/bridge/react/load-app.mdx
  • git diff --check

No package build was run because this PR only changes docs examples.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 28, 2026

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit e9545fe
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/6a18022ebd3eab0008fe3e1f
😎 Deploy Preview https://deploy-preview-4777--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 28, 2026

Open in StackBlitz

@module-federation/devtools

pnpm add https://pkg.pr.new/@module-federation/devtools@e9545fe

@module-federation/cli

pnpm add https://pkg.pr.new/@module-federation/cli@e9545fe

create-module-federation

pnpm add https://pkg.pr.new/create-module-federation@e9545fe

@module-federation/dts-plugin

pnpm add https://pkg.pr.new/@module-federation/dts-plugin@e9545fe

@module-federation/enhanced

pnpm add https://pkg.pr.new/@module-federation/enhanced@e9545fe

@module-federation/error-codes

pnpm add https://pkg.pr.new/@module-federation/error-codes@e9545fe

@module-federation/esbuild

pnpm add https://pkg.pr.new/@module-federation/esbuild@e9545fe

@module-federation/managers

pnpm add https://pkg.pr.new/@module-federation/managers@e9545fe

@module-federation/manifest

pnpm add https://pkg.pr.new/@module-federation/manifest@e9545fe

@module-federation/metro

pnpm add https://pkg.pr.new/@module-federation/metro@e9545fe

@module-federation/metro-plugin-rnc-cli

pnpm add https://pkg.pr.new/@module-federation/metro-plugin-rnc-cli@e9545fe

@module-federation/metro-plugin-rnef

pnpm add https://pkg.pr.new/@module-federation/metro-plugin-rnef@e9545fe

@module-federation/metro-plugin-rock

pnpm add https://pkg.pr.new/@module-federation/metro-plugin-rock@e9545fe

@module-federation/modern-js

pnpm add https://pkg.pr.new/@module-federation/modern-js@e9545fe

@module-federation/modern-js-v3

pnpm add https://pkg.pr.new/@module-federation/modern-js-v3@e9545fe

@module-federation/native-federation-tests

pnpm add https://pkg.pr.new/@module-federation/native-federation-tests@e9545fe

@module-federation/native-federation-typescript

pnpm add https://pkg.pr.new/@module-federation/native-federation-typescript@e9545fe

@module-federation/nextjs-mf

pnpm add https://pkg.pr.new/@module-federation/nextjs-mf@e9545fe

@module-federation/node

pnpm add https://pkg.pr.new/@module-federation/node@e9545fe

@module-federation/observability-plugin

pnpm add https://pkg.pr.new/@module-federation/observability-plugin@e9545fe

@module-federation/retry-plugin

pnpm add https://pkg.pr.new/@module-federation/retry-plugin@e9545fe

@module-federation/rsbuild-plugin

pnpm add https://pkg.pr.new/@module-federation/rsbuild-plugin@e9545fe

@module-federation/rspack

pnpm add https://pkg.pr.new/@module-federation/rspack@e9545fe

@module-federation/rspress-plugin

pnpm add https://pkg.pr.new/@module-federation/rspress-plugin@e9545fe

@module-federation/runtime

pnpm add https://pkg.pr.new/@module-federation/runtime@e9545fe

@module-federation/runtime-core

pnpm add https://pkg.pr.new/@module-federation/runtime-core@e9545fe

@module-federation/runtime-tools

pnpm add https://pkg.pr.new/@module-federation/runtime-tools@e9545fe

@module-federation/sdk

pnpm add https://pkg.pr.new/@module-federation/sdk@e9545fe

@module-federation/storybook-addon

pnpm add https://pkg.pr.new/@module-federation/storybook-addon@e9545fe

@module-federation/third-party-dts-extractor

pnpm add https://pkg.pr.new/@module-federation/third-party-dts-extractor@e9545fe

@module-federation/treeshake-frontend

pnpm add https://pkg.pr.new/@module-federation/treeshake-frontend@e9545fe

@module-federation/treeshake-server

pnpm add https://pkg.pr.new/@module-federation/treeshake-server@e9545fe

@module-federation/typescript

pnpm add https://pkg.pr.new/@module-federation/typescript@e9545fe

@module-federation/utilities

pnpm add https://pkg.pr.new/@module-federation/utilities@e9545fe

@module-federation/webpack-bundler-runtime

pnpm add https://pkg.pr.new/@module-federation/webpack-bundler-runtime@e9545fe

@module-federation/bridge-react

pnpm add https://pkg.pr.new/@module-federation/bridge-react@e9545fe

@module-federation/bridge-react-webpack-plugin

pnpm add https://pkg.pr.new/@module-federation/bridge-react-webpack-plugin@e9545fe

@module-federation/bridge-shared

pnpm add https://pkg.pr.new/@module-federation/bridge-shared@e9545fe

@module-federation/bridge-vue3

pnpm add https://pkg.pr.new/@module-federation/bridge-vue3@e9545fe

@module-federation/inject-external-runtime-core-plugin

pnpm add https://pkg.pr.new/@module-federation/inject-external-runtime-core-plugin@e9545fe

commit: e9545fe

@2heal1 2heal1 marked this pull request as ready for review May 28, 2026 08:51
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 28, 2026

⚠️ No Changeset found

Latest commit: e9545fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@2heal1 2heal1 merged commit 7c13b7b into main May 28, 2026
26 checks passed
@2heal1 2heal1 deleted the fix/4599-react-loading-docs branch May 28, 2026 11:17
@2heal1 2heal1 mentioned this pull request Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[doc] bridge-react loading example is wrong

1 participant