fix(devtools): guard invalid module info payloads#4787
Conversation
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
🦋 Changeset detectedLatest commit: 2884962 The changes in this PR will be included in the next version bump. This PR includes changesets to release 46 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/esbuild
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/metro-plugin-rock
@module-federation/modern-js
@module-federation/modern-js-v3
@module-federation/native-federation-tests
@module-federation/native-federation-typescript
@module-federation/nextjs-mf
@module-federation/node
@module-federation/observability-plugin
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/storybook-addon
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/typescript
@module-federation/utilities
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
Bundle Size Report10 package(s) changed, 31 unchanged. Package dist + ESM entry
Bundle targets
Consumer scenarios
Total dist (raw): 6.81 MB (+1.7 kB (+0.0%)) Bundle sizes are generated with rslib (Rspack). Package-root metrics preserve the historical report. Tracked subpath exports such as |
Description
Fixes a Chrome DevTools crash when Loading Trace is enabled and the Module Info tab is selected after refreshing the inspected page.
Invalid
moduleInfopayloads such as"[undefined]"can be relayed and stored aswindow.__FEDERATION__.moduleInfo, then later crash the Module Info renderer when it treats the value as a module snapshot.This change:
window.__FEDERATION__Verified with:
pnpm --filter @module-federation/devtools testpnpm exec turbo run build --filter=@module-federation/devtoolspnpm --filter @module-federation/devtools run build:devtoolNote:
pnpm exec turbo run lintwas attempted, but repo-wide lint currently fails in unrelatedapps/node-dynamic-remote-new-versionfiles due to existingrequire/moduleno-undeferrors. The changed DevTools package has no lint task.Related Issue
Fixes #4786
Types of changes
Checklist