fix(retry-plugin): externalize runtime types from DTS bundle#4853
Merged
ScriptedAlchemy merged 3 commits intoJul 2, 2026
Conversation
🦋 Changeset detectedLatest commit: 3a8ef80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 47 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0930f8e4b9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ScriptedAlchemy
approved these changes
Jul 2, 2026
ScriptedAlchemy
left a comment
ScriptedAlchemy
left a comment
Member
There was a problem hiding this comment.
Verified end to end: built the branch and confirmed dist/index.d.ts now imports ModuleFederationRuntimePlugin from @module-federation/runtime instead of inlining the types (the source of the consumer type-incompatibility), while the JS bundles contain no runtime import (type-only usage is elided), so there is no runtime behavior change. runtime-core does not appear in the emitted d.ts, so the single @module-federation/runtime peer dependency is sufficient. Tests pass 16/16.
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/esbuild
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/metro-plugin-rock
@module-federation/modern-js
@module-federation/modern-js-v3
@module-federation/native-federation-tests
@module-federation/native-federation-typescript
@module-federation/nextjs-mf
@module-federation/node
@module-federation/observability-plugin
@module-federation/playground
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/storybook-addon
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/typescript
@module-federation/utilities
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
ScriptedAlchemy
merged commit c103676
into
module-federation:main
34 of 38 checks passed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@module-federation/retry-pluginwas not listing@module-federation/runtimeand@module-federation/runtime-corein the external array of itstsdown.config.ts. As a result, the DTS bundler was inlining all type definitions from runtime-core directly into dist/index.d.ts instead of referencing them externally.This caused TypeScript to treat ModuleFederationRuntimePlugin from
@module-federation/runtimeand the inlined copy insideretry-plugin/dist/index.d.tsas two different type origins — even though they are structurally identical — leading to errors like:Type 'ModuleFederationRuntimePlugin' is not assignable to type 'ModuleFederationRuntimePlugin'in any consumer that uses both
@module-federation/runtimeand@module-federation/retry-plugintogether.The fix adds
@module-federation/runtimeand@module-federation/runtime-coreto the external array, matching the pattern already used by@module-federation/observability-plugin. This reduces dist/index.d.ts from 22.85 kB to 2.98 kB and eliminates the type incompatibility.Related Issue
N/A — discovered while upgrading from
@module-federation/retry-plugin@0.19.1 to 2.6.0Types of changes
Checklist