feat(website): deploy Rspress docs with Zephyr#4855
Conversation
❌ Deploy Preview for module-federation-docs failed. Why did it fail? →
|
|
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/esbuild
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/metro-plugin-rock
@module-federation/modern-js
@module-federation/modern-js-v3
@module-federation/native-federation-tests
@module-federation/native-federation-typescript
@module-federation/nextjs-mf
@module-federation/node
@module-federation/observability-plugin
@module-federation/playground
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/storybook-addon
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/typescript
@module-federation/utilities
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
Bundle Size Report2 package(s) changed, 40 unchanged. Package dist + ESM entry
Bundle targets
Consumer scenarios
Total dist (raw): 35.69 MB (+91 B (+0.0%)) Bundle sizes are generated with rslib (Rspack). Package-root metrics preserve the historical report. Tracked subpath exports such as Bundle errors
|
Nsttt
changed the title
|
🚀 Preview Environment Ready!
Details:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 139995586c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - 'apps/website-new/**' | ||
| - 'packages/rspress-plugin/**' |
There was a problem hiding this comment.
This workflow only wakes up for apps/website-new and packages/rspress-plugin, but website-new also directly consumes workspace packages such as @module-federation/runtime and @module-federation/error-codes. A PR or main push that changes packages/runtime/** or packages/error-codes/** without touching the root package files will not run this workflow, so the Zephyr preview/production docs can keep serving bundles built against the old workspace code. Please add the website's other workspace dependency paths, or avoid the narrow path filter.
Useful? React with 👍 / 👎.
| process.env.CONTEXT === 'deploy-preview' | ||
| ? process.env.DEPLOY_PRIME_URL | ||
| : 'https://module-federation.io/', | ||
| assetPrefix: `${siteOrigin}/`, |
There was a problem hiding this comment.
On pull_request builds this now resolves to https://module-federation.io/ because the workflow sets SITE_ORIGIN globally and the old DEPLOY_PRIME_URL preview branch was removed. Since this value is used as Rsbuild's assetPrefix, Zephyr preview HTML will request its JS/CSS and other Rspress assets from the production site instead of the preview deployment, making preview URLs show stale production assets for docs/theme/runtime changes. Keep the asset prefix relative or derive it from the Zephyr preview URL for PR builds.
Useful? React with 👍 / 👎.
|
@ScriptedAlchemy please help check this ~ |
|
@2heal1 will do! |
We can sync to have it deployed to your account and everything anytime |
Nsttt
force-pushed
the
codex/add-zephyr-rspress-plugin
branch
from
9fe757a to
46f87a1
Compare
4 participants
Description
Moves the Rspress website deployment path from Netlify to Zephyr.
zephyr-rspress-plugintoapps/website-newwithZephyr()after the existing Module Federation Rspress pluginWebsite Zephyr DeployGitHub Actions workflow usingZE_SECRET_TOKENpnpm run build:websiteon PR events beforeZephyrCloudIO/zephyr-preview-environment-action@v0.1.1, so the action can read the Zephyr deploy result and comment the PR preview URLZE_SECRET_TOKENandSITE_ORIGINthrough Turbo forwebsite-new#buildrspress.config.tspnpm-lock.yamlfor the new dependency treeRelated Issue
Direct maintainer request; no issue provided.
Types of changes
Checklist
Validation:
docs-listcompleted; existing docs front matter is missing summary keys.pnpm exec prettier --check apps/website-new/package.json apps/website-new/rspress.config.ts pnpm-lock.yamlpassed.pnpm exec prettier --check .github/workflows/website-zephyr.yml apps/website-new/rspress.config.ts turbo.jsonpassed.pnpm exec prettier --check .github/workflows/website-zephyr.yml turbo.jsonpassed after PR-build ordering changes.git diff --checkpassed.pnpm run ci:local --only=actionlintran; repo-local runner skipsactionlintas GitHub-only.committerpre-commit formatting/lint hooks completed for all commits; Turbo had nolinttask forwebsite-new.pnpm --filter website-new run buildreached Rspress build output, then failed in Zephyr upload withZE10019/ 403 because the local user is not allowed to updatewebsite-new.core.module-federation.Skipped / not complete:
ZE_SECRET_TOKEN/account permission forwebsite-new.core.module-federation.actionlintis validated by GitHub Actions in this repo; the local runner intentionally skips it.