-
Notifications
You must be signed in to change notification settings - Fork 94
feat: Vite runtime #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Vite runtime #277
Conversation
|
It looks like my changes to use lint-staged don't play nice with prettier-quick. I was wondering about that... Fix incoming. |
|
Fix to the linter in #278 |
|
Any idea why this MR isn't running my new E2E pipeline for the new library? Does it have to be merged first? I had thought changes made to the CI run in those change's PR? |
|
Turns out you cant specify working directory on anything other than a |
gioboa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this amazing help @SunsetFi
This creates the runtime package pre-tree-shaken for @module-federation/vite
It has some small improvements over my prototype:
@module-federation/sdkisBrowserEnvdirectly, and allows the ESM code analysis to flow-through and tree-shake everything, which it does wonderfully well. This is much more elegant than replacing calls to that function, but it does mean we need to ensure this library is always working with the ESM build, not the CommonJS one.