Skip to content

Conversation

@vergilfromadyen
Copy link
Contributor

@vergilfromadyen vergilfromadyen commented Nov 17, 2025

It looks like the warning was introduced in this commit.
getPublicPath was restored a day later in this commit, but the warning is still in the code.

Nowadays publicPath and getPublicPath are still in the code, so these options don't appear to actually be ignored.

Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @vergilfromadyen 👏

@vergilfromadyen vergilfromadyen changed the title Removed a false warning fix: Removed a false warning Nov 18, 2025
@vergilfromadyen vergilfromadyen changed the title fix: Removed a false warning fix: removed a warning that falsely warns that getPublicPath is ignored Nov 18, 2025
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vergilfromadyen

The warning is to highlight that "experimental.renderBuiltUrl" is used but right now we are still using getPublicPath 🤔

@gioboa gioboa merged commit ce8a819 into module-federation:main Nov 18, 2025
4 checks passed
@vergilfromadyen vergilfromadyen deleted the remove-warning branch November 18, 2025 09:21
@vergilfromadyen
Copy link
Contributor Author

vergilfromadyen commented Nov 18, 2025

Thanks @gioboa for merging this. Any chance we could get a patch release so I can un-spam my console? :)

Also, a migration example would be nice when this actually ends up being removed.
My case is that I'm using it as

getPublicPath: `function() {
  const url = new URL(document.baseURI);
  return document.baseURI + 'some-subpath' + url.pathname + '${domain}/'; // domain is declared elsewhere in the file
}`

I couldn't replicate that with experimental.renderBuiltUrl, granted I didn't really spend any meaningful amount of time trying to and opted to remove the warning upstream.

@gioboa
Copy link
Collaborator

gioboa commented Nov 18, 2025

Any chance we could get a patch release so I can un-spam my console? :)

There we go 1.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants