Skip to content

fix: removed a warning that falsely warns that getPublicPath is ignored #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

fix: removed a warning that falsely warns that getPublicPath is ignored #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/utils/logUtils.ts
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions src/utils/normalizeModuleFederationOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export type RemoteEntryType =

import * as fs from 'fs';
import * as path from 'pathe';
import { warn } from './logUtils';

interface ExposesItem {
import: string;
Expand Down Expand Up @@ -403,12 +402,6 @@ export function getNormalizeShareItem(key: string) {
export function normalizeModuleFederationOptions(
options: ModuleFederationOptions
): NormalizedModuleFederationOptions {
if (options.getPublicPath) {
warn(
`We are ignoring the getPublicPath options because they are natively supported by Vite\nwith the "experimental.renderBuiltUrl" configuration https://vitejs.dev/guide/build#advanced-base-options`
);
}

if (options.virtualModuleDir && options.virtualModuleDir.includes('/')) {
throw new Error(
`Invalid virtualModuleDir: "${options.virtualModuleDir}". ` +
Expand Down