fix: use protocol relative fallback origin#687
Merged
gioboa merged 2 commits intomodule-federation:mainfrom May 4, 2026
Merged
fix: use protocol relative fallback origin#687gioboa merged 2 commits intomodule-federation:mainfrom
gioboa merged 2 commits intomodule-federation:mainfrom
Conversation
simonihmig
commented
May 4, 2026
commit: |
gioboa
reviewed
May 4, 2026
gioboa
reviewed
May 4, 2026
Collaborator
gioboa
left a comment
gioboa
left a comment
There was a problem hiding this comment.
Tests With Different Frameworks
gioboa
approved these changes
May 4, 2026
Collaborator
gioboa
left a comment
gioboa
left a comment
There was a problem hiding this comment.
Thanks @simonihmig for your amazing help 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our setup, we use
ignoreOriginand also have vite configured to run on TLS. That used to work, prior to #638, but since then it had a hardcodedhttp://fallback origin, so theremoteEntry.jsrequest using http would fail to get served by vite listening on https. This change is making use of a protocol relative URL (//host), as it seems to have been before.