fix: handle side-effect only modules in normalizeRuntimeShare#718
Merged
gioboa merged 2 commits intoMay 18, 2026
Merged
Conversation
commit: |
gioboa
reviewed
May 18, 2026
Collaborator
gioboa
left a comment
There was a problem hiding this comment.
Thanks for your amazing help @simonihmig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is fixing an issue if your shared deps cover a module without exports (only side-effects). Ran into this when sharing
lit/which coverslit/polyfill-support. The browser seems to expose this with an (empty) special module namespace object asdefault. The__mfNormalizeRuntimeSharefunction would then return this one instead of the original module object. In theconst exportModule = normalizedModule === mod ? {...mod} : normalizedModule;statement,normalizedModulewould not be equal tomod, so it would try todefinePropertyon that namespace object, which fails as that is a exotic esm object that you cannot mutate.This can be reproduced when adding
lit/in the lit example app here.