feat(application-template): hook에서 ArgoCD hook annotation 지원 추가#45
Merged
feat(application-template): hook에서 ArgoCD hook annotation 지원 추가#45
Conversation
Helm hook annotation만 지원하던 hook 템플릿에 ArgoCD hook annotation을 선택적으로 사용할 수 있도록 수정. 각 job에 argocd 블록을 설정하면 argocd.argoproj.io/hook, sync-wave, hook-delete-policy annotation이 적용되며, 미설정 시 기존 helm.sh/hook 동작을 유지함 (하위 호환). vault Secret에도 동일하게 vault.argocd 블록으로 ArgoCD annotation 지원. nil pointer 접근 버그(vault 미설정 시 vault.enabled 참조) 함께 수정.
helm-unittest을 사용하여 hooks 템플릿의 ArgoCD/Helm hook annotation 렌더링을 검증하는 테스트 스위트 추가. 총 26개 테스트 케이스로 Job, Secret, ServiceAccount의 annotation 동작을 커버. 테스트 파일은 helm package 아티팩트에서 제외되도록 .helmignore에 tests/ 경로 추가. README에 테스트 설치 및 실행 방법 문서화.
hschoi1104
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hook.jobs[].argocd블록 설정 시 ArgoCD annotation 사용, 미설정 시 기존 Helm hook 동작 유지 (하위 호환)hook.jobs[].vault.argocd블록으로 vault Secret에도 동일하게 적용vault미설정 시 nil pointer 버그 수정:.vault대신(.vault)사용하면 js의 ?? 처럼 nil일때도 오류 안난다고 합니다.Usage
Jira: MD-23431 MD-23568