fix(api): не перезаписывать properties заказа данными адреса#195
Merged
Conversation
…properties (#191) array_merge($order->toArray(), $address->toArray()) caused the address properties (often null) to overwrite order properties in the API response. Extract mergeAddressIntoOrderData() that excludes conflicting fields (id, order_id, createdon, updatedon, properties) and use it in get(), create() and finalize() endpoints.
16 tasks
- Remove unrelated #174 entries from CHANGELOG (blocker) - Add PHPDoc note explaining why extra fields are loaded separately in get() but not in create()/finalize()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
array_merge($order->toArray(), $address->toArray())перезаписывалmsOrder.propertiesзначениемnullизmsOrderAddress.propertiesmergeAddressIntoOrderData()с исключением конфликтующих полей (id,order_id,createdon,updatedon,properties)array_mergeна новый метод вget(),create(),finalize()get()заменёнgetObject(msOrderAddress, ...)наgetOne('Address')Closes #191
Test plan
ms3_orders.properties(например, через доставку с доп. данными)msOrderAddress.properties=nullGET /api/mgr/orders/{id}—propertiesдолжен содержать данные заказа, а неnullpropertiesсохраняется в ответе