MOEN-44005 Personalize

[AnirudhaSM-engg-sdk]

Jira Ticket

https://moengagetrial.atlassian.net/browse/MOEN-44005

Description

Added personalize feature module and support

[msoumya-engg-sdk]

Verification Review

This PR was verified against:

• Contract: mobile-sdk-contracts#29
• Tech doc: Personalize Experience - Hybrid SDK Implementation
• Existing module coding standards (cards, inbox, core)

Contract Alignment — mostly correct

• Public API signatures, JSON payload shapes (singular vs plural), Promise-vs-fire-and-forget patterns, and error handling paths all align with the tech doc and contract PR.
• 2 model-level deviations flagged inline:
  • ExperienceCampaign.experienceContext typed as Record<string, any> instead of Record<string, string> (contract violation).
  • ExperienceCampaignFailure.message field is not in the contract/tech doc.

Coding Standards — significant gaps vs cards module

• No MoEngageLogger usage anywhere — parser uses raw console.warn; handler and public API have zero logging. The cards module demonstrates the established pattern (verbose at entry, debug for init, error on failure).
• No MODULE_TAG constant and no per-class TAG strings for log prefixes.
• Handler is standalone functions — cards uses a class with private TAG/appId.
• Constants naming diverges (UPPER_CASE vs the key-prefixed camelCase in cards).
• package.json files field contains phantom entries and is missing key exclusions.

Test Coverage — gaps identified

• Parser: Array.isArray(...) else-branches, missing data key, malformed JSON for parseExperiencesResult, unknown source per-experience.
• Public API: fetchExperiences(keys, attrs) with explicit attrs not tested; resolved Promise values never asserted.
• Handler: parsed-field round-trip not verified (only array lengths).
• PayloadBuilder: empty-input edge cases untested.

Missing Component

• No Android native bridge code present. Please confirm whether this is a separate follow-up PR.

Inline comments on specific lines/files provide concrete suggested fixes for each item.

---

Generated by Claude Code

[msoumya-engg-sdk]

Follow-up Review: Coding Standards & Logging Gaps

This is a follow-up to the prior verification review, adding inline comments for issues 2–10 from the earlier "not added" list, plus additional logging gaps identified across the module.

Coding standards deviations (vs. cards reference module)

• Public API uses class instead of the repo-standard namespace — flagged for team discussion
• Internal filenames are prefixed with MoEPersonalize* (redundant inside internal/)
• No internal/utils/ subdirectory for utility helpers
• Native bridge registered as 'MoEReactPersonalize' (older pattern) vs. cards' 'MoEngageCardsBridge'
• Parser file combines extraction + mapping — cards splits these into two files
• Models have no JSDoc (@author/@since) tags
• Type style uses Record<string, any> instead of the codebase-standard { [k: string]: any }
• Extra babel-jest devDependency not present in other modules
• ExperienceCampaignFailure.reason typed as string — loses compile-time safety over known failure reasons; suggested string-literal union

Logging gaps (additional to the previous review)

• iOS native handler (MoEReactNativePersonalizeHandler.m) — zero logging. No entry traces, no error logging on the rejection path, no logging on NSJSONSerialization failure, duplicated resolve/reject code between fetchExperiencesMeta and fetchExperiences that should be extracted into a helper with centralized logging.
• Parser — doesn't log entry traces, malformed-payload warnings, or missing-field warnings. Silent defaults hide server/bridge issues.
• PayloadBuilder → Handler — the outgoing JSON payload and native response are not logged anywhere on the JS side, making the bridge flow entirely opaque in debug traces. At minimum, the handler should log payload-in / response-out at verbose.
• serializeCampaign — no warning when payload or experienceContext is null/undefined; malformed inputs produce silently-broken wire payloads.

Inline comments contain concrete suggested fixes for each item.

---

Generated by Claude Code

[msoumya-engg-sdk]

Changes LGTM. Once dependencies for this PR are released, update the versions and run the iOS CI.

NitPick: Update the PR description to a more meaningful one.