fix: update alerter blacklist count when resources are deleted#1166
Closed
litlmike wants to merge 1 commit intomoghtech:mainfrom
Closed
fix: update alerter blacklist count when resources are deleted#1166litlmike wants to merge 1 commit intomoghtech:mainfrom
litlmike wants to merge 1 commit intomoghtech:mainfrom
Conversation
Filter out non-existent resources when displaying the blacklist/whitelist count in the alerter config UI. Previously, deleting a resource that was on an alerter's blacklist would show a stale count until the backend cleanup propagated. Closes moghtech#581
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alerter blacklist counts now correctly exclude deleted resources. Previously, deleting a resource that was on an alerter's blacklist would leave a stale reference, showing an incorrect count.
Closes #581