Make listener address configurable & Add support for IPv6#405
Make listener address configurable & Add support for IPv6#405mbecker20 merged 3 commits intomoghtech:1.17.1from
Conversation
There was a problem hiding this comment.
Thanks for the PR! I've just updated it to merge to 1.17.1 branch so I can include it in the next release.
I do have a change to request, I think the name listener_address may lead to some confusion about what this does, and may lead to users inputing their server's local IP address or something like that. I think my preferred term is bind_ip. This more closely matches the mongo configuration for example, they use bindIp for this: https://www.mongodb.com/docs/manual/reference/configuration-options/#net-options.
I also left a couple comments clarifying the inline docs.
|
Made the requested changes :) |
* interpolate into slack / discord url
* fix js client docs
* js client should be type: module
* click table tags to toggle tag filter
* git token helper early return when empty provider
* reorder Stack fields
* action support interpolation doc
* Fix for the {account} login fails when the account name contains '$' (#385)
* GetDeploymentsSummary (#386)
* added GetDockerContainersSummary endpoint in rust api
* typescript stuff
* more autogenned typescript stuff
* fixed comments to be in line with actual behaviour
* fixed ReadResponse for GetDockerContainersSummary
* I64 -> u32 for response types
* more accurate error context
* backend for build files on host / ui defined
* core api supports non repo based build
* Ntfy as Alerter (#404)
* add ntfy alerter
* add ntfy alerter
* add ntfy alerter
---------
Co-authored-by: GFXSpeed <github@schafhaupt.com>
* Improve docs around running periphery in a container (#402)
* Add ports that need to be exposed if periphery is remote from core
* Spelling: overide -> override
* Add info about using a custom config file when running periphery in docker
* clean up ntfy alerter
* clean up ResourceSyncConfig
* update build cache after create / update
* refresh stack cache log
* Build UI Defined / file on host frontend
* update clap + rustls
* don't cleanup build files
* clean up dockerfile full path
* update BuildListItemInfo + UI table
* add Other Resources page
* add 5 second ws reconnection timeout
* Make listener address configurable & Add support for IPv6 (#405)
* Make listener address configurable
* Make listener address configurable for periphery
* rename listener_address -> bind_ip
---------
Co-authored-by: Jacky Fong <hello@huzky.dev>
Co-authored-by: Alex Shore <kntrllr@gmail.com>
Co-authored-by: Niklas <108990063+GFXSpeed@users.noreply.github.com>
Co-authored-by: GFXSpeed <github@schafhaupt.com>
Co-authored-by: theRAAPster <theraapster@gmail.com>
Co-authored-by: Daniel Vos <45820840+vosdev@users.noreply.github.com>
|
@vosdev, why did you make IPv6 as default? With IPv6 as the default, users must adjust their configurations to include the |
This PR makes the listener address configurable for both Core and Periphery through the following env vars:
CORE_LISTENER_ADDRESSPERIPHERY_LISTENER_ADDRESSBut the main purpose of this PR is to add support for IPv6.
Before:
After:
Fixes #313