Skip to content

Update illegal-move notation strings for Playground #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mogproject merged 1 commit into from
Dec 27, 2017
Merged

Update illegal-move notation strings for Playground #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shared/src/main/scala/com/mogproject/mogami/core/move/SpecialMove.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ case class IllegalMove(move: Move) extends SpecialMove {

override def toUsenString: String = IllegalMove.usenKeyword + move.toUsenString

override def toJapaneseNotationString: String = IllegalMove.kifKeyword
override def toJapaneseNotationString: String = move.toJapaneseNotationString

override def toWesternNotationString: String = "Illegal Move"
override def toWesternNotationString: String = move.toWesternNotationString

override def toKi2String(currentPlayer: Player, numMoves: Int): String =
makeKi2String(numMoves, s"${(!currentPlayer).toJapaneseNotationString()}の${IllegalMove.ki2Keyword}勝ち")
Expand Down
18 changes: 18 additions & 0 deletions shared/src/test/scala/com/mogproject/mogami/core/move/SpecialMoveSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package com.mogproject.mogami.core.move

import com.mogproject.mogami.core.state.State
import org.scalatest.prop.GeneratorDrivenPropertyChecks
import org.scalatest.{FlatSpec, MustMatchers}


class SpecialMoveSpec extends FlatSpec with MustMatchers with GeneratorDrivenPropertyChecks {

"IllegalMove#toJapaneseNotationString" must "return move expression" in {
IllegalMove(MoveBuilderCsa.parseCsaString("+7776FU").toMove(State.HIRATE).get).toJapaneseNotationString mustBe "７六歩"
}

"IllegalMove#toWestern" must "return move expression" in {
IllegalMove(MoveBuilderCsa.parseCsaString("+7776FU").toMove(State.HIRATE).get).toWesternNotationString mustBe "P-7f"
}

}