Prepare v0.21.0 release#143
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
📝 WalkthroughWalkthroughThis PR releases v0.21.0 by bumping the package version, creating a changelog entry, updating documentation to remove v0.20 references, and adding a test to ensure package.json and package-lock.json versions remain synchronized. Changesv0.21.0 Release with Version Validation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/unit/package-metadata.test.ts (1)
110-116: ⚡ Quick winAssert version presence before equality checks for clearer failures.
If both values are unexpectedly absent, equality can still pass; explicit presence assertions make regressions easier to diagnose.
Proposed test hardening
it('keeps package.json and package-lock.json on the same release version', () => { const manifest = loadPackageManifest() const packageLock = loadPackageLock() + expect(manifest.version).toBeTruthy() + expect(packageLock.version).toBeTruthy() + expect(packageLock.packages?.['']?.version).toBeTruthy() expect(packageLock.version).toBe(manifest.version) expect(packageLock.packages?.['']?.version).toBe(manifest.version) })🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/unit/package-metadata.test.ts` around lines 110 - 116, Add explicit presence assertions before equality checks: ensure manifest.version and packageLock.version and packageLock.packages?.['']?.version are defined (use expect(...).toBeDefined()) prior to the existing expect(...).toBe(...) calls. Update the test that uses loadPackageManifest() and loadPackageLock() (variables manifest and packageLock) to first assert presence of these properties so failures show missing values instead of silently passing equality checks.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/unit/package-metadata.test.ts`:
- Around line 110-116: Add explicit presence assertions before equality checks:
ensure manifest.version and packageLock.version and
packageLock.packages?.['']?.version are defined (use expect(...).toBeDefined())
prior to the existing expect(...).toBe(...) calls. Update the test that uses
loadPackageManifest() and loadPackageLock() (variables manifest and packageLock)
to first assert presence of these properties so failures show missing values
instead of silently passing equality checks.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: be5d11bf-8f5b-41f1-9805-5fa7778a5ae4
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
CHANGELOG.mdREADME.mddocs/benchmarks/2026-05-11-spi-vs-legacy/README.mdpackage.jsontests/unit/package-metadata.test.ts
Summary
Verification
Release note
Summary by CodeRabbit