Improve graph tool routing guidance#29
Conversation
Route installed graphify guidance by question type so native agents use the focused MCP tools instead of over-centralizing retrieve. Also cap Vitest workers at 4 so the full suite stays stable on shared machines. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughInstallation guidance now routes tool usage by question type (choose among Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer/Agent
participant Installer as install.ts
participant MCP as MCP Server (graph tools)
participant FS as Raw File Store
Dev->>Installer: run claudeInstall / geminiInstall
Installer->>Dev: inject MCP_ROUTING_GUIDANCE into pre-tool message
Dev->>MCP: ask question -> choose tool by question type (e.g., relevant_files)
MCP-->>Dev: graph-tool answer (feature_map / risk_map / etc.)
alt MCP cannot answer or unavailable
Dev->>FS: use raw-file search (retrieve / read)
FS-->>Dev: file contents
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Review rate limit: 9/10 reviews remaining, refill in 6 minutes. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/unit/install.test.ts`:
- Around line 236-239: The test assertions checking the generated GEMINI.md are
missing an assertion for the routing-token "impact"; update the assertions that
call readFileSync(join(projectDir, 'GEMINI.md'), 'utf8') to also include
expect(...).toContain('impact') so the test covers the impact section for both
occurrences (the block around the current expect(...).toContain('relevant_files'
/ 'feature_map' / 'risk_map' / 'implementation_checklist') and the other similar
block later in the file).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: b146c2c5-4f66-47e8-9464-5e08a5c2fe01
📒 Files selected for processing (5)
src/infrastructure/install.tstests/unit/install-templates.test.tstests/unit/install.test.tstests/unit/package-metadata.test.tsvitest.config.ts
Cover the impact routing token in the generated Gemini and Claude install guidance tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary
Testing
Summary by CodeRabbit
New Features
Tests