docs: add install compatibility guide#442
Conversation
Closes #424 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
📝 WalkthroughWalkthroughThis PR adds install compatibility documentation and comprehensive verification tests for supported agent platforms. A new user-facing compatibility guide documents the install matrix for both dedicated installers and ChangesInstall Compatibility Documentation and Verification
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/unit/install-compatibility.test.ts (1)
454-456: ⚡ Quick winAlso assert the
.madar_versionsibling marker.The guide states every home-skill install writes
SKILL.mdplus a sibling.madar_versionmarker (and theverifytext repeats it), but the artifact assertions only checkSKILL.md. Asserting the marker too tightens drift detection per the PR's "detect changes in install templates" goal.💚 Proposed marker assertion
- installSkill(row.platform, { homeDir, packageRoot: bundledPackageRoot, version: 'test-version' }) - - expectArtifacts(homeDir, getHomeSkillArtifacts(row.platform)) + installSkill(row.platform, { homeDir, packageRoot: bundledPackageRoot, version: 'test-version' }) + + const homeArtifacts = getHomeSkillArtifacts(row.platform) + expectArtifacts(homeDir, homeArtifacts) + for (const skill of homeArtifacts.filter((a) => a.endsWith('SKILL.md'))) { + expectArtifacts(homeDir, [skill.replace(/SKILL\.md$/, '.madar_version')]) + }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/unit/install-compatibility.test.ts` around lines 454 - 456, The test currently calls installSkill(...) and then expectArtifacts(homeDir, getHomeSkillArtifacts(row.platform)) but only verifies SKILL.md; update the assertions to also check for the sibling marker file `.madar_version` — either by extending getHomeSkillArtifacts(row.platform) to include '.madar_version' or by adding an explicit assertion after installSkill (e.g., expect(fs.existsSync(path.join(homeDir, '<skill-dir>', '.madar_version'))).toBeTruthy()) so the test verifies both SKILL.md and the `.madar_version` marker; modify the test near installSkill / expectArtifacts to include the marker check.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/unit/install-compatibility.test.ts`:
- Around line 454-456: The test currently calls installSkill(...) and then
expectArtifacts(homeDir, getHomeSkillArtifacts(row.platform)) but only verifies
SKILL.md; update the assertions to also check for the sibling marker file
`.madar_version` — either by extending getHomeSkillArtifacts(row.platform) to
include '.madar_version' or by adding an explicit assertion after installSkill
(e.g., expect(fs.existsSync(path.join(homeDir, '<skill-dir>',
'.madar_version'))).toBeTruthy()) so the test verifies both SKILL.md and the
`.madar_version` marker; modify the test near installSkill / expectArtifacts to
include the marker check.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 16f8e95d-f874-4a33-8fc3-1e7b0afbb0ff
📒 Files selected for processing (3)
README.mddocs/integrations/compatibility.mdtests/unit/install-compatibility.test.ts
Summary
Testing
Closes #424
Summary by CodeRabbit
Documentation
Tests