Focus: fix itemview icons, rm globe-rotate-left-solid, add login icon #1922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Also related to #1923. |
Contributor
As noted in the PR fixing the Basic theme issues, the regular icons (CSS class "fa-regular") would match the previously used "-o" ones. Imo they also look better. I suggest having a look and judge by yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...
This change also moves the icon mapping from themes get_endpoint_iconmap() to constants/misc.
The '-o' suffix for Fontawesome icons like "fa-trash-o" has been removed, this seem to be a leftover from a version prior 6.x.
This also fixes missing icons in itemviews for different other themes.
Related to #1911 no. 3 and no. 7