-
Notifications
You must be signed in to change notification settings - Fork 3
fix(csi-1926): fixed missing Slack notifications of timeout #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces configurable timeout handling for test execution with improved reporting and exit codes. It extracts timeout constants to a centralized configuration file and adds support for timeout-specific notifications.
- Introduces
EXIT_CODESand configurableTESTS_EXECUTION_TIMEOUTin a new constants module - Adds
handleTimeoutfunction to generate timeout reports and send Slack notifications - Updates dependency versions for axios, commander, and npm-check-updates
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/constants.js | New file defining exit codes and configurable timeout constant from environment |
| src/router.js | Updated to use centralized constants and call new handleTimeout function |
| src/modes/outbound.js | Added handleTimeout function to generate timeout reports and send notifications |
| src/extras/slack-broadcast.js | Added sendTimeoutSlackNotification function and timeout emoji support |
| src/utils/report.js | Added blank lines for code formatting |
| test/unit/router.test.js | Updated test to use new constants instead of hardcoded values |
| package.json | Updated dependency versions |
| package-lock.json | Updated lock file with new dependency versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.