Merged
Conversation
…Root) Move duplicated root-parsing logic and the required-root error into the s2 package so that s3, gcs, and azblob backends share a single implementation.
mojatter
force-pushed
the
refactor/shared-config-helpers
branch
from
3b2e578 to
6b12abe
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ErrRequiredConfigRootto thes2package as the single source of truths2.ParseRootto replace duplicated root-parsing logic ins3,gcs, andazblobcfg.Rootvalidation tofs.NewStorageforosfs(previously allowed empty root, which silently used the current directory)Test plan
TestParseRootinconfig_test.goTestNewStorageOSFSEmptyRootinfs/storage_test.gogolangci-lint run ./...reports 0 issues