Skip to content

refactor: remove typecheck configurations and related tsconfig files#141

Merged
luxass merged 1 commit intomainfrom
refactor_remove_typecheck_configurations_and_related_tsconfig_files
Apr 25, 2025
Merged

refactor: remove typecheck configurations and related tsconfig files#141
luxass merged 1 commit intomainfrom
refactor_remove_typecheck_configurations_and_related_tsconfig_files

Conversation

@luxass
Copy link
Copy Markdown
Member

@luxass luxass commented Apr 24, 2025

By doing this we are reducing the amount of Typechecks we are running down from 2, to 1.

This will speedup the CI pipeline by a small margin.

Summary by CodeRabbit

  • Chores
    • Removed package-specific TypeScript test configuration files.
    • Updated test configuration to eliminate type checking for test declaration files in several packages.
    • Adjusted CI workflow to change the order of type checking in the process.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 24, 2025

⚠️ No Changeset found

Latest commit: e7d5b46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2025

Walkthrough

This update removes all tsconfig.test.json files from multiple packages, eliminating package-specific TypeScript configurations for test declaration files. Correspondingly, the Vitest configuration is updated to remove the typecheck blocks that referenced these deleted files, discontinuing explicit type checking of test declaration files during testing. Additionally, the CI workflow is adjusted to move the typecheck step to immediately follow the lint step, changing the order of execution without altering the step's content.

Changes

File(s) Change Summary
.github/workflows/ci.yaml Reordered the CI workflow steps, moving typecheck to immediately after lint.
packages/adapters/tsconfig.test.json,
packages/cli/tsconfig.test.json,
packages/internal-utils/tsconfig.test.json,
packages/parsers/tsconfig.test.json,
packages/schemas/tsconfig.test.json,
packages/versions/tsconfig.test.json
Deleted all package-specific tsconfig.test.json files for test declaration type checking.
vitest.config.ts Removed typecheck configuration blocks for affected packages, discontinuing test declaration type checks.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub Actions
    participant Lint
    participant Typecheck
    participant Test

    GitHub Actions->>Lint: Run lint step
    Lint->>Typecheck: Run typecheck step (moved up)
    Typecheck->>Test: Run test step
Loading

Suggested labels

pkg: internal-utils, pkg: adapters, pkg: cli

Poem

In the garden of code, the configs did grow,
But today the test tsconfigs had to go.
Typechecks now follow lint in the CI parade,
A tidier workflow, with clutter mislaid.
The rabbit hops on, with whiskers held high—
For every clean change, it gives a soft sigh!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 27e253e and e7d5b46.

📒 Files selected for processing (8)
  • .github/workflows/ci.yaml (1 hunks)
  • packages/adapters/tsconfig.test.json (0 hunks)
  • packages/cli/tsconfig.test.json (0 hunks)
  • packages/internal-utils/tsconfig.test.json (0 hunks)
  • packages/parsers/tsconfig.test.json (0 hunks)
  • packages/schemas/tsconfig.test.json (0 hunks)
  • packages/versions/tsconfig.test.json (0 hunks)
  • vitest.config.ts (0 hunks)
💤 Files with no reviewable changes (7)
  • packages/versions/tsconfig.test.json
  • packages/parsers/tsconfig.test.json
  • packages/internal-utils/tsconfig.test.json
  • packages/adapters/tsconfig.test.json
  • packages/schemas/tsconfig.test.json
  • packages/cli/tsconfig.test.json
  • vitest.config.ts
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: zizmor
🔇 Additional comments (1)
.github/workflows/ci.yaml (1)

39-40: Surface type errors before test execution
Moving the typecheck step to immediately follow lint ensures type violations are caught early—saving time by preventing tests from running on type-erroring code.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions Bot added pkg: internal-utils changes related to the internal-utils pkg pkg: adapters changes related to the adapters pkg pkg: cli changes related to the cli pkg pkg: parsers changes related to the parsers pkg pkg: schemas labels Apr 24, 2025
Copy link
Copy Markdown
Member Author

luxass commented Apr 24, 2025

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Member Author

luxass commented Apr 25, 2025

Merge activity

  • Apr 25, 9:42 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 25, 9:42 AM EDT: @luxass merged this pull request with Graphite.

@luxass luxass merged commit 216bbf6 into main Apr 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: adapters changes related to the adapters pkg pkg: cli changes related to the cli pkg pkg: internal-utils changes related to the internal-utils pkg pkg: parsers changes related to the parsers pkg pkg: schemas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant