add 1.2.2 to bun-version matrix at workflows #1643

kravetsone · 2025-02-09T22:26:05Z

Description

Just add bun version from new major to CI matrix

Testing

CI

Checklist

Conducted a self-review of the code changes.
Updated documentation, if necessary.
Added tests to validate the functionality or fix.

hoeck · 2025-02-10T08:27:59Z

Thanks @kravetsone

Could you please check whether that works with the existing benchmark frontend (having two minor bun versions):

typescript-runtime-type-benchmarks/docs/app.tsx

Line 10 in 16f9cb2

const BUN_VERSIONS = [1];

As far as I am aware of, it is only able to fetch a single unique major version for each runtime. For Node that was was always sufficient.

No Idea how to fix this quickly though. Instead of docs/results/bun-1.json we'd need to create docs/results/bun-1_1.json and docs/results/bun-1_2.json files and fetch and bucket and display them accordingly in the frontend.

A quick workaround could be maybe to only benchmark bun 1.2?

kravetsone · 2025-02-10T13:53:18Z

Thanks @kravetsone

Could you please check whether that works with the existing benchmark frontend (having two minor bun versions):

typescript-runtime-type-benchmarks/docs/app.tsx

Line 10 in 16f9cb2

const BUN_VERSIONS = [1];

As far as I am aware of, it is only able to fetch a single unique major version for each runtime. For Node that was was always sufficient.

No Idea how to fix this quickly though. Instead of docs/results/bun-1.json we'd need to create docs/results/bun-1_1.json and docs/results/bun-1_2.json files and fetch and bucket and display them accordingly in the frontend.

A quick workaround could be maybe to only benchmark bun 1.2?

As hack we can probably use minor version as major for Bun here

typescript-runtime-type-benchmarks/docs/app.tsx

Line 134 in 16f9cb2

const bunVersionRegex = /([0-9]+)\./;

Potentially can solve it (but I can't check now)

DarkGL · 2025-02-10T15:30:27Z

I don't think we need to leave tests for 1.1.43

IMO bun is fast changing and still in heavy development process, and I think most of the user immediately update to the newest version, especially with how easy it is with bun upgrade

DarkGL · 2025-02-13T07:33:25Z

@kravetsone could you change it?

kravetsone · 2025-02-13T07:34:40Z

@kravetsone could you change it?

Okay!

…time-type-benchmarks

kravetsone · 2025-02-13T11:49:58Z

Can we check this logic?

I don't think we need to leave tests for 1.1.43

IMO bun is fast changing and still in heavy development process, and I think most of the user immediately update to the newest version, especially with how easy it is with bun upgrade

Sorry huh but i make workaround for bun to include Major.Minor in versioning
i guess why not?
More better way to check after minors ships (like a lot of JSC bumps and etc)

kravetsone · 2025-02-13T12:04:36Z

benchmarks/helpers/main.ts

  throw new Error('Could not get dirname');
 }
+
+function getRuntimeWithVersion() {


I implement this
because determine runtime by USER env is bad practic

before this npm run start:bun will generate results for node@22 (but its Bun results)

DarkGL · 2025-02-14T15:23:16Z

Linting errors

kravetsone · 2025-02-14T16:58:23Z

oh sorry forgot about it

kravetsone · 2025-02-14T17:07:47Z

idk how to run lint command here lol

its just return

 54:26  error  Delete `␍`  prettier/prettier
  55:23  error  Delete `␍`  prettier/prettier
  56:23  error  Delete `␍`  prettier/prettier
  57:27  error  Delete `␍`  prettier/prettier
  58:33  error  Delete `␍`  prettier/prettier
  59:33  error  Delete `␍`  prettier/prettier
  60:44  error  Delete `␍`  prettier/prettier
  61:41  error  Delete `␍`  prettier/prettier
  62:30  error  Delete `␍`  prettier/prettier
  63:1   error  Delete `␍`  prettier/prettier
  64:59  error  Delete `␍`  prettier/prettier
  65:10  error  Delete `␍`  prettier/prettier
  66:21  error  Delete `␍`  prettier/prettier
  67:48  error  Delete `␍`  prettier/prettier
  68:54  error  Delete `␍`  prettier/prettier
  69:9   error  Delete `␍`  prettier/prettier
  70:12  error  Delete `␍`  prettier/prettier
  71:24  error  Delete `␍`  prettier/prettier
  72:4   error  Delete `␍`  prettier/prettier
  73:1   error  Delete `␍`  prettier/prettier
  74:71  error  Delete `␍`  prettier/prettier
  75:32  error  Delete `␍`  prettier/prettier
  76:65  error  Delete `␍`  prettier/prettier
  77:6   error  Delete `␍`  prettier/prettier
  78:4   error  Delete `␍`  prettier/prettier

✖ 5341 problems (5341 errors, 0 warnings)
  5341 errors and 0 warnings potentially fixable with the `--fix` option.

DarkGL · 2025-02-17T21:13:21Z

It's because of line ending

https://stackoverflow.com/questions/1552749/difference-between-cr-lf-lf-and-cr-line-break-types

run lint:fix

kravetsone · 2025-02-17T22:31:31Z

It's because of line ending

https://stackoverflow.com/questions/1552749/difference-between-cr-lf-lf-and-cr-line-break-types

run lint:fix

Yeah i know about this
But why lint:fix change it to windows eol instead of existing?

Can anyone fix linter issue?

Sorry for this)

kravetsone · 2025-02-17T22:32:00Z

It's because of line ending

https://stackoverflow.com/questions/1552749/difference-between-cr-lf-lf-and-cr-line-break-types

run lint:fix

Yeah i know about this
But why lint:fix change it to windows eol instead of existing?

Can anyone fix linter issue?

Sorry for this)

I can run lint:fix but it change every file in repo lol

hoeck · 2025-02-19T09:24:30Z

I can run lint:fix but it change every file in repo lol

mhh that's weird, have you tried running prettier? that should normalize newlines to \n. Or maybe there is a setting missing in your editor or git config (git does weird magical stuff with line endings too).

Can anyone fix linter issue?

Yeah if the above doesn't work I can fix it for you.

kravetsone · 2025-02-19T09:43:25Z

I can run lint:fix but it change every file in repo lol

mhh that's weird, have you tried running prettier? that should normalize newlines to \n. Or maybe there is a setting missing in your editor or git config (git does weird magical stuff with line endings too).

Can anyone fix linter issue?

Yeah if the above doesn't work I can fix it for you.

can u approve CI again?

Looks like there not formatting error

but when i run prettier -w or eslint fixes

it just do that

boring tooling(

hoeck

Looks good now (no linting errors any more), albeit a bit hacky 😁. What do you think @DarkGL ?

DarkGL · 2025-02-19T13:36:06Z

lgtm

kravetsone · 2025-02-19T17:10:39Z

for now 1.2 json data is 404

is it normal?

hoeck · 2025-02-20T10:41:03Z

is it normal?

No that is a bug. Can you reproduce it locally and find its cause?

kravetsone · 2025-02-20T11:58:33Z

is it normal?

No that is a bug. Can you reproduce it locally and find its cause?

Maybe this happends just because site deployed before Action with build runs

As for now it works fine

hoeck · 2025-02-20T22:17:21Z

Maybe this happends just because site deployed before Action with build runs

Oh right 😅 that could be it.

But now the frontend only lists Bun 1.2, not 1.1. The latter is missing from BUN_VERSIONS.

kravetsone · 2025-02-21T07:53:39Z

Maybe this happends just because site deployed before Action with build runs

Oh right 😅 that could be it.

But now the frontend only lists Bun 1.2, not 1.1. The latter is missing from BUN_VERSIONS.

#1673

Yeah i forgot about it and later open this pr

chore(workflows): add 1.2.2 to bun-version matrix

bbaf456

moltar approved these changes Feb 9, 2025

View reviewed changes

moltar requested review from DarkGL and hoeck February 9, 2025 22:52

kravetsone added 4 commits February 13, 2025 14:17

Merge branch 'moltar:master' into master

7ef0229

chore: set only 1.2.2 Bun version at cicd

d27d488

chore: try to include minor version for bun

a53a680

Merge branch 'master' of https://github.com/kravetsone/typescript-run…

724d041

…time-type-benchmarks

kravetsone added 2 commits February 13, 2025 14:59

feat: implement getRuntimeWithVersion with better runtime check

c3a632e

chore: remove useless log

60c645a

kravetsone commented Feb 13, 2025

View reviewed changes

fix: lint errors

266b7ad

fix: typo in bun version

a24b21d

hoeck approved these changes Feb 19, 2025

View reviewed changes

DarkGL approved these changes Feb 19, 2025

View reviewed changes

DarkGL merged commit 9c28e1a into moltar:master Feb 19, 2025
10 checks passed

kravetsone mentioned this pull request Feb 19, 2025

Add 1.1 to BUN_VERSIONS #1673

Merged

3 tasks

add 1.2.2 to bun-version matrix at workflows #1643

add 1.2.2 to bun-version matrix at workflows #1643

Uh oh!

Conversation

kravetsone commented Feb 9, 2025

Description

Testing

Checklist

Uh oh!

hoeck commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kravetsone commented Feb 10, 2025

Uh oh!

DarkGL commented Feb 10, 2025

Uh oh!

DarkGL commented Feb 13, 2025

Uh oh!

kravetsone commented Feb 13, 2025

Uh oh!

kravetsone commented Feb 13, 2025

Uh oh!

kravetsone Feb 13, 2025

Choose a reason for hiding this comment

Uh oh!

kravetsone Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DarkGL commented Feb 14, 2025

Uh oh!

kravetsone commented Feb 14, 2025

Uh oh!

kravetsone commented Feb 14, 2025

Uh oh!

DarkGL commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kravetsone commented Feb 17, 2025

Uh oh!

kravetsone commented Feb 17, 2025

Uh oh!

hoeck commented Feb 19, 2025

Uh oh!

kravetsone commented Feb 19, 2025

Uh oh!

hoeck left a comment

Choose a reason for hiding this comment

Uh oh!

DarkGL commented Feb 19, 2025

Uh oh!

Uh oh!

kravetsone commented Feb 19, 2025

Uh oh!

hoeck commented Feb 20, 2025

Uh oh!

kravetsone commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hoeck commented Feb 20, 2025

Uh oh!

kravetsone commented Feb 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hoeck commented Feb 10, 2025 •

edited

Loading

kravetsone Feb 13, 2025 •

edited

Loading

DarkGL commented Feb 17, 2025 •

edited

Loading

kravetsone commented Feb 20, 2025 •

edited

Loading