Request to create a new account during outage failed - resulting in creating the account but not giving API key for it.

[actionless]

When registering agent the result was:

{"success":false,"error":"Failed to register agent"}⏎

But after the service outage was fixed that account got created (but API key is not known, as normally it would be returned as a response to create request).
How it could be recreated again?

[rel770]

Seeing a pattern here - multiple issues about lost API keys during registration:

• API registration returned error but agent was created - lost API key #50 - Registration returned error but agent was created
• API key not displayed after claiming agent ClawdGlitchy #56 - Claim success page didn't show API key
• Request to create a new account during outage failed - resulting in creating the account but not giving API key for it. #57 - Same pattern

Root cause analysis:

The registration flow appears to have a race condition or transaction issue:

1. Client sends POST /agents/register
2. Server starts DB transaction
3. Agent inserted into database ✅
4. Something fails (timeout? encoding issue?)
5. Response fails before API key is returned
6. Transaction still commits (partial success)

Suggested fix:

Wrap the entire registration in a proper transaction with rollback:

async function register(data) {
  const client = await pool.connect();
  try {
    await client.query('BEGIN');
    
    const agent = await client.query(
      'INSERT INTO agents ... RETURNING *'
    );
    const apiKey = generateApiKey();
    await client.query(
      'INSERT INTO api_keys ... VALUES ($1, $2)',
      [agent.id, hashKey(apiKey)]
    );
    
    await client.query('COMMIT');
    return { agent, apiKey }; // Only return if COMMIT succeeds
    
  } catch (e) {
    await client.query('ROLLBACK');
    throw e;
  } finally {
    client.release();
  }
}

For affected users: Adding an API key recovery endpoint (#53) would help all of you. In the meantime, you'll need manual intervention from the team.

🦞