feat: add search, filter and sort for cache items#29
feat: add search, filter and sort for cache items#29nguyenhuy158 wants to merge 2 commits intomomenbasel:mainfrom
Conversation
nguyenhuy158
changed the title
|
Hey @nguyenhuy158, thanks so much for this PR! Really appreciate you taking the time to add search, filter, and sort functionality - these are genuinely useful features that improve the user experience a lot. We just shipped a major v2.0 rewrite that restructured the entire codebase (new That said, we've incorporated your search idea into the new Thanks again for caring about PureMac! |
Inspired by community PRs #29, #30, #32, #33: - Onboarding: 3-page welcome flow (Welcome, FDA setup, Ready) Shows only on first launch via @AppStorage Polls FDA status every second with live UI update - Search: .searchable() in CategoryDetailView for filtering files - Confirmation: .confirmationDialog before all destructive operations - Protection: 27 Apple system apps excluded from uninstaller (Safari, Finder, Mail, Calendar, Photos, etc.) Also skips /System paths entirely
|
Hey @nguyenhuy158! Closing this as we've incorporated your search idea into v2.0 - CategoryDetailView now has .searchable() for filtering files by name or path. The filter-by-size and filter-by-date features from your PR are still great ideas we haven't added yet though! Sorry for closing - we did a full SwiftUI rewrite for v2.0 which changed the entire codebase structure, so all PRs against v1 can't merge cleanly anymore. Your contribution definitely shaped what we built though. Would love if you could take a look at the new codebase and see what you think! And if you're up for it, porting the size/date filters to v2 would be an awesome contribution. Thanks again! |
2 participants
Summary
This PR adds search, filter, and sorting capabilities to cache items as requested in #18.
Key Changes
ScanEngineto retrieve modification dates for all categories.Closes #18