feat: add Chinese (Simplified) localization#8
Merged
momenbasel merged 1 commit intomomenbasel:mainfrom Apr 10, 2026
Merged
Conversation
- Add en.lproj/Localizable.strings and zh-Hans.lproj/Localizable.strings - Register zh-Hans language and Localizable.strings in Xcode project - Wrap enum rawValues and descriptions with LocalizedStringKey in all views - Fix GradientActionButton title type to LocalizedStringKey - Localize "Never" / "Not scheduled" in ScheduleConfig via String(localized:) - Localize notification body via NSLocalizedString Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
Thanks for the contribution! Clean localization work — the Chinese translations look solid and the SwiftUI integration follows standard patterns. Merged. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
en.lproj/Localizable.stringsandzh-Hans.lproj/Localizable.stringswith 100+ translated stringszh-Hanslanguage andLocalizable.stringsin Xcode project (PBXVariantGroup + Resources build phase)rawValue/descriptionreferences in views withLocalizedStringKeyso they resolve correctlyGradientActionButton.titlefromStringtoLocalizedStringKeyfor proper localization of button labels"Never"/"Not scheduled"inScheduleConfigviaString(localized:)NSLocalizedStringTest plan
🤖 Generated with Claude Code