fix: use != instead of is not #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on https://realpython.com/python-is-identity-vs-equality/, `is not` operator compares if two variables refer to the same object in memory. Hence switching to != and == comparisons. Although the types being compared are `int` and fall within range, it seems like the comaprison being made is incorrect. Why only the bug reporter can reproduce this but not any of us is still a mystery to me. So unfortunately, I cannot test this fix apart from some theoretical reading that I did. Nonetheless, this should fix it for everyone is my solid hope. ``` >>> import momento_wire_types.cacheclient_pb2 as cache_client_types >>> get_resp = cache_client_types.GetResponse() >>> type(get_resp) <class 'cacheclient_pb2.GetResponse'> >>> type(get_resp.result) <class 'int'> >>> type(cache_client_types.Hit) <class 'int'> ```
Contributor
Author
bruuuuuuuce
reviewed
Jan 7, 2022
Contributor
bruuuuuuuce
left a comment
bruuuuuuuce
left a comment
There was a problem hiding this comment.
Do we also want to change all the other is not to != in this repo?
Contributor
Author
I believe these are the only ones that compare values. The others are |
Contributor
Ok cool, the rest are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://realpython.com/python-is-identity-vs-equality/,
is notoperator compares if two variables refer to the same object in memory. Hence switching to != and == comparisons. Although the types being compared areintand fall within range, it seems like the comaprison being made is incorrect.Why only the bug reporter can reproduce this but not any of us is still a mystery to me. So unfortunately, I cannot test this fix apart from some theoretical reading that I did.
Nonetheless, this should fix it for everyone is my solid hope.