Skip to content

fix: use != instead of is not #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2022
Merged

fix: use != instead of is not #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/momento/cache_operation_responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class CacheResult(Enum):
class CacheSetResponse:
def __init__(self, grpc_set_response, value):
self._value = value
if (grpc_set_response.result is not cache_client_types.Ok):
if (grpc_set_response.result != cache_client_types.Ok):
_momento_logger.debug(f'Set received unsupported ECacheResult {grpc_set_response.result}')
raise error_converter.convert_ecache_result(
grpc_set_response.result, grpc_set_response.message, 'SET')
Expand All @@ -28,16 +28,15 @@ class CacheGetResponse:
def __init__(self, grpc_get_response):
self._value = grpc_get_response.cache_body

if (grpc_get_response.result is not cache_client_types.Hit
and grpc_get_response.result is not cache_client_types.Miss):
if (grpc_get_response.result == cache_client_types.Hit):
self._result = CacheResult.HIT
elif (grpc_get_response.result == cache_client_types.Miss):
self._result = CacheResult.MISS
else:
_momento_logger.debug(f'Get received unsupported ECacheResult: {grpc_get_response.result}')
raise error_converter.convert_ecache_result(
grpc_get_response.result, grpc_get_response.message, 'GET')

if (grpc_get_response.result == cache_client_types.Hit):
self._result = CacheResult.HIT
if (grpc_get_response.result == cache_client_types.Miss):
self._result = CacheResult.MISS

def str_utf8(self):
if (self._result == CacheResult.HIT):
Expand Down